giac 1.7.0-29 on i686

Bugs

Modérateur : xcasadmin

frederic han
Messages : 1137
Inscription : dim. mai 20, 2007 7:09 am
Localisation : Paris
Contact :

giac 1.7.0-29 on i686

Message par frederic han » dim. sept. 05, 2021 11:02 am

Dear Bernard,
here is a report from Antonio T. (fedora packager for giac) on i686
best Frederic

Code : Tout sélectionner

/bin/sh ../libtool  --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H -I. -I..  -DIN_GIAC -I. -I.. -I. -I..       -std=gnu++14 -O2  -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m32 -march=i686 -mtune=generic -msse2 -mfpmath=sse -mstackrealign -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-strict-aliasing -DGIAC_GENERIC_CONSTANTS -DTIMEOUT -DHAVE_LIBMICROPYTHON -fpermissive -DQUICKJS -c -o graphe.lo graphe.cc

libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I.. -DIN_GIAC -I. -I.. -I. -I.. -std=gnu++14 -O2 -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m32 -march=i686 -mtune=generic -msse2 -mfpmath=sse -mstackrealign -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fno-strict-aliasing -DGIAC_GENERIC_CONSTANTS -DTIMEOUT -DHAVE_LIBMICROPYTHON -fpermissive -DQUICKJS -c graphe.cc  -fPIC -DPIC -o .libs/graphe.o

In file included from giacPCH.h:8,

                 from graphe.cc:20:

index.h:33: warning: ignoring '#pragma anon_unions ' [-Wunknown-pragmas]

   33 | #pragma anon_unions

      |

In file included from giacPCH.h:32,

                 from graphe.cc:20:

gen.h: In constructor 'giac::eqwdata::eqwdata(int, int, int, int, const giac::attributs&, const giac::gen&)':

gen.h:1406:15: warning: 'giac::eqwdata::eqw_attributs' will be initialized after [-Wreorder]

 1406 |     attributs eqw_attributs;

      |               ^~~~~~~~~~~~~

gen.h:1399:9: warning:   'int giac::eqwdata::x' [-Wreorder]

 1399 |     int x,y,dx,dy;

      |         ^

gen.h:1407:5: warning:   when initialized here [-Wreorder]

 1407 |     eqwdata(int dxx,int dyy,int xx, int yy,const attributs & a,const gen& gg):g(gg),eqw_attributs(a),x(xx),y(yy),dx(dxx),dy(dyy),selected(false),active(false),hasbaseline(false),modifiable(true),baseline(0) {};

      |     ^~~~~~~

gen.h:1405:10: warning: 'giac::eqwdata::modifiable' will be initialized after [-Wreorder]

 1405 |     bool modifiable;

      |          ^~~~~~~~~~

gen.h:1400:9: warning:   'int giac::eqwdata::baseline' [-Wreorder]

 1400 |     int baseline;

      |         ^~~~~~~~

gen.h:1407:5: warning:   when initialized here [-Wreorder]

 1407 |     eqwdata(int dxx,int dyy,int xx, int yy,const attributs & a,const gen& gg):g(gg),eqw_attributs(a),x(xx),y(yy),dx(dxx),dy(dyy),selected(false),active(false),hasbaseline(false),modifiable(true),baseline(0) {};

      |     ^~~~~~~

gen.h: In constructor 'giac::eqwdata::eqwdata(int, int, int, int, const giac::attributs&, const giac::gen&, int)':

gen.h:1406:15: warning: 'giac::eqwdata::eqw_attributs' will be initialized after [-Wreorder]

 1406 |     attributs eqw_attributs;

      |               ^~~~~~~~~~~~~

gen.h:1399:9: warning:   'int giac::eqwdata::x' [-Wreorder]

 1399 |     int x,y,dx,dy;

      |         ^

gen.h:1408:5: warning:   when initialized here [-Wreorder]

 1408 |     eqwdata(int dxx,int dyy,int xx, int yy,const attributs & a,const gen& gg,int mybaseline):g(gg),eqw_attributs(a),x(xx),y(yy),dx(dxx),dy(dyy),selected(false),active(false),hasbaseline(true),modifiable(true),baseline(mybaseline) {};

      |     ^~~~~~~

gen.h:1405:10: warning: 'giac::eqwdata::modifiable' will be initialized after [-Wreorder]

 1405 |     bool modifiable;

      |          ^~~~~~~~~~

gen.h:1400:9: warning:   'int giac::eqwdata::baseline' [-Wreorder]

 1400 |     int baseline;

      |         ^~~~~~~~

gen.h:1408:5: warning:   when initialized here [-Wreorder]

 1408 |     eqwdata(int dxx,int dyy,int xx, int yy,const attributs & a,const gen& gg,int mybaseline):g(gg),eqw_attributs(a),x(xx),y(yy),dx(dxx),dy(dyy),selected(false),active(false),hasbaseline(true),modifiable(true),baseline(mybaseline) {};

      |     ^~~~~~~

graphe.cc: In static member function 'static giac::gen giac::graphe::sparse_product_element(const sparsemat&, const sparsemat&, int, int)':

graphe.cc:3947:9: warning: unused variable 'r' [-Wunused-variable]

 3947 |     int r,c;

      |         ^

graphe.cc: In member function 'void giac::graphe::tsp::formulate_mip()':

graphe.cc:10972:46: warning: unused variable 'nrows0' [-Wunused-variable]

10972 |     int nonzeros=0,i,j,k,l,cnt=0,nrows,ncols,nrows0;

      |                                              ^~~~~~

graphe.cc: In member function 'giac::graphe::yen::tree_node* giac::graphe::yen::store_path(const ivector&, giac::graphe::yen::tree_node*)':

graphe.cc:13318:11: warning: unused variable 'j' [-Wunused-variable]

13318 |     int i,j,n=path.size();

      |           ^

graphe.cc: In member function 'bool giac::graphe::mvc(giac::graphe::ivector&, int, int, int, double, bool)':

graphe.cc:14717:14: warning: unused variable 'last_cov_size' [-Wunused-variable]

14717 |     int c=-1,last_cov_size=0,cov_size,s,s0,cmp;

      |              ^~~~~~~~~~~~~

graphe.cc:14717:30: warning: unused variable 'cov_size' [-Wunused-variable]

14717 |     int c=-1,last_cov_size=0,cov_size,s,s0,cmp;

      |                              ^~~~~~~~

graphe.cc: In member function 'void giac::graphe::mvc_bipartite(const ivector&, const ivector&, giac::graphe::ivector&, int, bool)':

graphe.cc:14890:13: warning: variable 'u' set but not used [-Wunused-but-set-variable]

14890 |         int u,v,w;

      |             ^

graphe.cc: In member function 'void giac::graphe::identify_from_sequences(giac::graphe::ivectors&, int)':

graphe.cc:15690:31: warning: comparison of integer expressions of different signedness: 'int' and 'std::size_t' {aka 'unsigned int'} [-Wsign-compare]

15690 |                     if (maxdeg!=be.count())

      |                         ~~~~~~^~~~~~~~~~~~

graphe.cc:15707:43: error: conversion from 'giac::ulong' {aka 'long unsigned int'} to 'const giac::gen' is ambiguous

15707 |                         G.make_haar_graph(n);

      |                                           ^

In file included from giacPCH.h:32,

                 from graphe.cc:20:

gen.h:653:5: note: candidate: 'giac::gen::gen(const giac_float&)'

  653 |     gen(const giac_float & f);

      |     ^~~

gen.h:651:5: note: candidate: 'giac::gen::gen(double)'

  651 |     gen(double d);

      |     ^~~

gen.h:638:5: note: candidate: 'giac::gen::gen(longlong)'

  638 |     gen(longlong i);

      |     ^~~

gen.h:637:5: note: candidate: 'giac::gen::gen(long int)'

  637 |     gen(long i);

      |     ^~~

gen.h:631:5: note: candidate: 'giac::gen::gen(size_t)'

  631 |     gen(size_t i): type(_INT_),subtype(0),val((int)i)  {

      |     ^~~

gen.h:626:5: note: candidate: 'giac::gen::gen(int)'

  626 |     gen(int i): type(_INT_),subtype(0),val(i) {

      |     ^~~

graphe.cc:6008:41: note:   initializing argument 1 of 'bool giac::graphe::make_haar_graph(const giac::gen&)'

 6008 | bool graphe::make_haar_graph(const gen &n) {

      |                              ~~~~~~~~~~~^

In file included from index.h:21,

                 from giacPCH.h:8,

                 from graphe.cc:20:

vector.h: In instantiation of 'void std::imvector<_Tp>::resize(std::size_t) [with _Tp = giac::gen; std::size_t = unsigned int]':

graphe.cc:172:15:   required from here

vector.h:301:18: warning: unused variable 'prev' [-Wunused-variable]

  301 |         unsigned prev=_taille==immvector_max?0:_abs(_taille);

      |                  ^~~~

make[2]: *** [Makefile:992: graphe.lo] Error 1

parisse
Messages : 5734
Inscription : mar. déc. 20, 2005 4:02 pm
Contact :

Re: giac 1.7.0-29 on i686

Message par parisse » lun. sept. 06, 2021 11:09 am

Can be fixed by

Code : Tout sélectionner

diff graphe.cc graphe.cc~
15707c15707
< 		      G.make_haar_graph(int(n));
---
>                         G.make_haar_graph(n);

sagitter
Messages : 31
Inscription : sam. mai 14, 2016 6:19 pm
Localisation : Italy

Re: giac 1.7.0-29 on i686

Message par sagitter » lun. sept. 06, 2021 6:04 pm

Hi Parisse.

I will try your patch soon.

PS. Thank you, Frederic.
mailto: sagitter 'at' fedoraproject 'dot' org
https://fedoraproject.org/wiki/User:Sagitter

sagitter
Messages : 31
Inscription : sam. mai 14, 2016 6:19 pm
Localisation : Italy

Re: giac 1.7.0-29 on i686

Message par sagitter » lun. sept. 06, 2021 6:13 pm

parisse a écrit :
lun. sept. 06, 2021 11:09 am
Can be fixed by

Code : Tout sélectionner

diff graphe.cc graphe.cc~
15707c15707
< 		      G.make_haar_graph(int(n));
---
>                         G.make_haar_graph(n);
That line is already in graphe.cc:

Code : Tout sélectionner

$ cat src/graphe.cc | grep G.make_haar_graph
                        G.make_haar_graph(n);
mailto: sagitter 'at' fedoraproject 'dot' org
https://fedoraproject.org/wiki/User:Sagitter

parisse
Messages : 5734
Inscription : mar. déc. 20, 2005 4:02 pm
Contact :

Re: giac 1.7.0-29 on i686

Message par parisse » lun. sept. 06, 2021 6:25 pm

Yes, graphe.cc is the working file (with int), while graphe.cc~ (without) is the non working backup file (from emacs).

sagitter
Messages : 31
Inscription : sam. mai 14, 2016 6:19 pm
Localisation : Italy

Re: giac 1.7.0-29 on i686

Message par sagitter » mar. sept. 07, 2021 3:27 pm

parisse a écrit :
lun. sept. 06, 2021 11:09 am
Can be fixed by

Code : Tout sélectionner

diff graphe.cc graphe.cc~
15707c15707
< 		      G.make_haar_graph(int(n));
---
>                         G.make_haar_graph(n);
This patch fixed the error on i686 and ARM.
Thank you.
mailto: sagitter 'at' fedoraproject 'dot' org
https://fedoraproject.org/wiki/User:Sagitter

Répondre