giac headers use undefined uchar type

[sagitter]

Hi again.

Original bug ticket in Fedora: 2160197

sagemath is failing to build against giac-1.9.0-35 with this error:

Code : Tout sélectionner

INFO: gcc: sage/libs/gsl/array.c
/usr/include/giac/plot.h:842:12: error: ‘uchar’ was not declared in this scope; did you mean ‘u_char’?
  842 | void blend(uchar r1,uchar g1,uchar b1,uchar r2,uchar g2,uchar b2,double t,uchar &r,uchar &g,uchar &b);
      |            ^~~~~
      |            u_char
/usr/include/giac/plot.h:842:21: error: ‘uchar’ was not declared in this scope; did you mean ‘u_char’?
  842 | void blend(uchar r1,uchar g1,uchar b1,uchar r2,uchar g2,uchar b2,double t,uchar &r,uchar &g,uchar &b);
      |                     ^~~~~
      |                     u_char
/usr/include/giac/plot.h:842:30: error: ‘uchar’ was not declared in this scope; did you mean ‘u_char’?
  842 | void blend(uchar r1,uchar g1,uchar b1,uchar r2,uchar g2,uchar b2,double t,uchar &r,uchar &g,uchar &b);
      |                              ^~~~~
      |                              u_char

[parisse]

Yes, this is already fixed
https://github.com/geogebra/giac/commit ... d8f0c8131e